Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature/745 fetch people search entries from ptime #748

Merged
merged 37 commits into from
Jul 29, 2024
Merged

feature/745 fetch people search entries from ptime #748

merged 37 commits into from
Jul 29, 2024

Conversation

ManuelMoeri
Copy link
Collaborator

No description provided.

@ManuelMoeri ManuelMoeri changed the title Feature/745 fetch people search entries from ptime feature/745 fetch people search entries from ptime Jul 4, 2024
@ManuelMoeri ManuelMoeri linked an issue Jul 5, 2024 that may be closed by this pull request
Fetch people search entries from ptime, else Skills fallback | PuzzleTime #6 #745
Open
4 tasks
ManuelMoeri added 18 commits July 5, 2024 15:47
@ManuelMoeri
Implement correct routing of person and fix a problem in the docker s…
3a6b7c0 
…etup with yminder
@ManuelMoeri
Possibly fix docker compose file
c25e18c
@ManuelMoeri
Fix tests and implement logic for sorting people
4385c4a
@ManuelMoeri
Implement logic for fallback and cleanup helper method
202006a
@ManuelMoeri
Improve fallback logic by making it more readable and shorter
1dc3065
@ManuelMoeri
Implement first approach on calling the ptime api after 5 minutes
1267736
@ManuelMoeri
Improve logic of 5 minutes request and change client.rb
512593b
@ManuelMoeri
Add logic to load site correctly and remove unnecessary code
c9e9825
@ManuelMoeri
Fix logic of rendering people and cleanup code
39acf6e
@ManuelMoeri
Add tests for person_helper
d967660
@ManuelMoeri
Add ptime_helpers to cleanup code
c657e8f
@ManuelMoeri
Fix tests
bcb3ebe
@ManuelMoeri
Fix last test and remove pry
456f27b
@ManuelMoeri
Fix test and add comment
4718e92
@ManuelMoeri
Generalize window resizing of capybara
bf771aa
@ManuelMoeri
Cleanup code and add comments
189ab80
@ManuelMoeri
Add one more test for client.rb
2e2ae6b
@ManuelMoeri
Reverse test from last commit
766e942
@kcinay055679 kcinay055679 self-assigned this Jul 24, 2024
@kcinay055679 kcinay055679 marked this pull request as ready for review July 26, 2024 10:50
@kcinay055679 kcinay055679 requested a review from Robin481 July 26, 2024 10:50
@Robin481 Robin481 removed their request for review July 29, 2024 06:30
@Robin481 Robin481 assigned kcinay055679 and unassigned Robin481 Jul 29, 2024
@kcinay055679 kcinay055679 changed the base branch from master to ptime-mapper-script July 29, 2024 07:15
@kcinay055679 kcinay055679 requested a review from Robin481 July 29, 2024 11:41
@kcinay055679 kcinay055679 merged commit 5411381 into ptime-mapper-script Jul 29, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Robin481 Robin481 Awaiting requested review from Robin481

Assignees

@Robin481 Robin481

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fetch people search entries from ptime, else Skills fallback | PuzzleTime #6
3 participants
@ManuelMoeri @Robin481 @kcinay055679