Feature/746 update or create with ptime employee data by RandomTannenbaum · Pull Request #749 · puzzle/skills

Commits on Jul 30, 2024

Remove unwanted things from delayed job and start writing updating and creating of people
RandomTannenbaum
committed
Make show method use new record if necessary
RandomTannenbaum
committed
Move new create and update logic to new class and make create redirect to people if they already exist
RandomTannenbaum
committed
Make newly created people have default languages, refactor code
RandomTannenbaum
committed
Start writing tests for updating person data on visit and remove specs and code from old updating version with delayed job
RandomTannenbaum
committed
Fix assigning and updating of nationalities and write test for creating a person
RandomTannenbaum
committed
Write a spec that tests if create_person can return an already existing person
RandomTannenbaum
committed
Write spec that tests ensures an error is raised when the person is not found in the ptime api
RandomTannenbaum
committed
Make create_person method directly create the correct person without creating a default person
RandomTannenbaum
committed
Clean up and fix specs, fix create_person method in update_person_data class
RandomTannenbaum
committed
Start updating default language logic
RandomTannenbaum
committed
Rename update_person_data from ptime namespace to people_employees
RandomTannenbaum
committed
Rename create_person method to create_or_find
RandomTannenbaum
committed
Change way in which default languages are set
RandomTannenbaum
committed
Update tests with new helpers
RandomTannenbaum
committed
Make person controller work without time again, start writing initializer that will enable the ptime connection when wanted, fix docker compose
RandomTannenbaum
committed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Feature/746 update or create with ptime employee data#749

Commits on Jul 30, 2024

Remove unwanted things from delayed job and start writing updating and creating of people

Make show method use new record if necessary

Move new create and update logic to new class and make create redirect to people if they already exist

Make newly created people have default languages, refactor code

Start writing tests for updating person data on visit and remove specs and code from old updating version with delayed job

Fix assigning and updating of nationalities and write test for creating a person

Write a spec that tests if create_person can return an already existing person

Write spec that tests ensures an error is raised when the person is not found in the ptime api

Make create_person method directly create the correct person without creating a default person

Clean up and fix specs, fix create_person method in update_person_data class

Start updating default language logic

Rename update_person_data from ptime namespace to people_employees

Rename create_person method to create_or_find

Change way in which default languages are set

Update tests with new helpers

Make person controller work without time again, start writing initializer that will enable the ptime connection when wanted, fix docker compose

Commits on Jul 31, 2024

Move setting of default languages to after_initialize and cleanup code

Move ptime connection to concerns and rename it to people_controller

Rename create_or_find to find_or_create

Fix a bug where default languages where added every time person was visited

Move some code from the update_person_data method to another method for better readabilty

Fix typo in people_employees

Write spec to test if default languages are created correctly

Change insert to prepend in ptime initializer

Commits on Aug 2, 2024

Simplify people_controller in ptime namespace

Rewrite people_employees feature spec as request spec

Fix ptime specs

Make rubocop happy

Make controller read person id from params and remove unwanted spec

Make ptime client correctly throw PTimeTemporarilyUnavailableError and write spec to test it

Check if correct template is rendered in ptime temporarely unavailable test

Replace config.to_prepare with config.after_initialize in ptime initializer