Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small accessibility push #4840

Merged
merged 1 commit into from
Oct 29, 2024
Merged

Small accessibility push #4840

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions components/manifest-editor/src/components/manifest-info-form.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -545,7 +545,7 @@ export class ManifestInfoForm extends LitElement {
<p class="field-desc">(required)</p>
</div>
<p class="field-desc">The name of your app as displayed to the user</p>
<sl-input placeholder="PWA Name" value=${this.manifest.name! || ""} data-field="name" @sl-change=${this.handleInputChange}></sl-input>
<sl-input placeholder="PWA Name" value=${this.manifest.name! || ""} data-field="name" @sl-change=${this.handleInputChange} required="true"></sl-input>
</div>
<div class="form-field">
<div class="field-header">
Expand All @@ -557,7 +557,7 @@ export class ManifestInfoForm extends LitElement {
<p class="field-desc">(required)</p>
</div>
<p class="field-desc">Used in app launchers</p>
<sl-input placeholder="PWA Short Name" value=${this.manifest.short_name! || ""} data-field="short_name" @sl-change=${this.handleInputChange}></sl-input>
<sl-input placeholder="PWA Short Name" value=${this.manifest.short_name! || ""} data-field="short_name" @sl-change=${this.handleInputChange} required="true"></sl-input>
</div>
</div>

Expand Down
2 changes: 1 addition & 1 deletion components/manifest-editor/src/components/manifest-settings-form.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -604,7 +604,7 @@ export class ManifestSettingsForm extends LitElement {
<p class="field-desc">(required)</p>
</div>
<p class="field-desc">The URL that loads when your PWA starts</p>
<sl-input placeholder="PWA Start URL" value=${this.manifest.start_url! || ""} data-field="start_url" @sl-change=${this.handleInputChange}></sl-input>
<sl-input placeholder="PWA Start URL" value=${this.manifest.start_url! || ""} data-field="start_url" @sl-change=${this.handleInputChange} required="true"></sl-input>
</div>
<div class="form-field">
<div class="field-header">
Expand Down
8 changes: 4 additions & 4 deletions components/manifest-editor/src/components/manifest-share-form.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -939,7 +939,7 @@ export class ManifestShareForm extends LitElement {
<p class="field-desc">(required)</p>
</div>
<p class="field-desc">The URL for the web share target </p>
<sl-input name="action" placeholder="Add action (ex: /share-receiver)" value=${this.manifest.share_target?.action! || ""} @sl-change=${() => this.handleTopLevelInputChange("action")} data-field="share_target.action"></sl-input>
<sl-input name="action" placeholder="Add action (ex: /share-receiver)" value=${this.manifest.share_target?.action! || ""} @sl-change=${() => this.handleTopLevelInputChange("action")} data-field="share_target.action" required="true"></sl-input>
<p class="action-error-message error-message">Action is a required field and must be in the scope of your PWA</p>
</div>
<div class="form-field">
Expand Down Expand Up @@ -997,7 +997,7 @@ export class ManifestShareForm extends LitElement {
<manifest-field-tooltip .field=${"share_target.params.title"}></manifest-field-tooltip>
</div>
</div>
<sl-input name="title" class="params" placeholder="Add title" value=${this.manifest.share_target?.params?.title! || ""} @sl-change=${() => this.handleParameterInputChange("title")} data-field="share_target.params.title"></sl-input>
<sl-input name="title" class="params" placeholder="Add title" value=${this.manifest.share_target?.params?.title! || ""} @sl-change=${() => this.handleParameterInputChange("title")} data-field="share_target.params.title" required="true"></sl-input>
</div>
<div class="form-field">
<div class="field-header">
Expand All @@ -1006,7 +1006,7 @@ export class ManifestShareForm extends LitElement {
<manifest-field-tooltip .field=${"share_target.params.text"}></manifest-field-tooltip>
</div>
</div>
<sl-input name="text" class="params" placeholder="Add text" value=${this.manifest.share_target?.params?.text! || ""} @sl-change=${() => this.handleParameterInputChange("text")} data-field="share_target.params.text"></sl-input>
<sl-input name="text" class="params" placeholder="Add text" value=${this.manifest.share_target?.params?.text! || ""} @sl-change=${() => this.handleParameterInputChange("text")} data-field="share_target.params.text" required="true"></sl-input>
</div>
<div class="form-field">
<div class="field-header">
Expand All @@ -1015,7 +1015,7 @@ export class ManifestShareForm extends LitElement {
<manifest-field-tooltip .field=${"share_target.params.url"}></manifest-field-tooltip>
</div>
</div>
<sl-input name="url" class="params" placeholder="Add url" value=${this.manifest.share_target?.params?.url! || ""} @sl-change=${() => this.handleParameterInputChange("url")} data-field="share_target.params.url"></sl-input>
<sl-input name="url" class="params" placeholder="Add url" value=${this.manifest.share_target?.params?.url! || ""} @sl-change=${() => this.handleParameterInputChange("url")} data-field="share_target.params.url" required="true"></sl-input>
</div>
</div>
<div class="form-row long">
Expand Down
Loading