-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Errors when spaces are present before/after bool values in the yaml files. #19
Merged
Merged
Changes from 3 commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
1a46d70
Adjusting selected parsing expresions to trim white spaces before/aft…
BitlyTwiser 3aa6d78
Moving bools out of 98YD to avoid bloat. Adding trim to int parsing. …
BitlyTwiser f20a082
Removing manual trim from various functions (string, int, bool) and c…
BitlyTwiser 0f622ed
Removing inline trim to clean up helper function
BitlyTwiser 2d268d4
Adjusting to PR feedback
BitlyTwiser File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,9 @@ | ||
elements: | ||
- name: Example Name | ||
bool_val: true | ||
int_val: 0 | ||
float_val: 3.14 | ||
- name: Example Name 2 | ||
bool_val: false | ||
int_val: 120 | ||
float_val: 56.123 |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,14 @@ | ||
elemennts: | ||
- name: Spec Example 5.5. Comment Indicator | ||
from: http://www.yaml.org/spec/1.2/spec.html#id2773032 | ||
tags: spec comment empty | ||
yaml: | | ||
# Comment only. | ||
tree: | | ||
+STR | ||
-STR | ||
json: "" | ||
dump: "" | ||
bool_val: true | ||
bool_val_b2: false | ||
bool_val_with_spaces: true |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -8,4 +8,4 @@ elemennts: | |
+STR | ||
-STR | ||
json: "" | ||
dump: "" | ||
dump: "" |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep, this works for me, but I think something like this would be a bit cleaner 🫶
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@BitlyTwiser just this small comment and we are ready to merge!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Certainly! I do enjoy the usage of the
getExpressionValue
here, I shall update as we speak!There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Huzzah! I made the following adjustments per your feedback:
Let me know if that seems nonsensical and I can adjust as needed 😄
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thanks again!