Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add initial support for protocol mode B #21

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

emontnemery
Copy link

This adds basic support for mode B:

  • Add baudrate map for mode B
  • Skip mode selection for standard readout

Accessing of programming mode is not implemented

@Krolken
Copy link
Contributor

Krolken commented Aug 18, 2021

Thanks for starting support for Mode B.

But I would prefer a separate Client object over a mode selection arg.

So to have
ModeCClient and ModeBClient

I think that would keep the code more maintainable and fixes for one type of meter would give less risk of breaking stuff for others.

Once A, D and E mode are implemented the code would othewise be filled with tons of if-statements making it hard to understand.

@emontnemery
Copy link
Author

OK, that sounds good!
Just to confirm, you mean refactoring by splitting out the specifics for each mode to subclasses of Iec6205621Client, which will then be an abstract class?

@Krolken
Copy link
Contributor

Krolken commented Aug 18, 2021

I started a discussion about it for better collaboration. #22

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants