Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Min row height in tables + docs on fpdf2 internals #1346

Merged
merged 2 commits into from
Jan 17, 2025

Conversation

Lucas-C
Copy link
Member

@Lucas-C Lucas-C commented Jan 13, 2025

Added

Docs preview

image
image

Checklist

  • A unit test is covering the code added / modified by this PR

  • This PR is ready to be merged

  • In case of a new feature, docstrings have been added, with also some documentation in the docs/ folder

  • A mention of the change is present in CHANGELOG.md

By submitting this pull request, I confirm that my contribution is made under the terms of the GNU LGPL 3.0 license.

@Lucas-C Lucas-C requested a review from gmischler as a code owner January 13, 2025 11:19
@Lucas-C Lucas-C force-pushed the docs-on-fpdf2-internals branch from 1599265 to 02b5165 Compare January 13, 2025 11:23
@Lucas-C Lucas-C marked this pull request as draft January 13, 2025 11:27
@Lucas-C Lucas-C changed the title Draft: Min row height in tables + docs on fpdf2 internals Min row height in tables + docs on fpdf2 internals Jan 13, 2025
@Lucas-C Lucas-C force-pushed the docs-on-fpdf2-internals branch 3 times, most recently from cda592f to f8ae2b2 Compare January 17, 2025 10:28
@Lucas-C Lucas-C marked this pull request as ready for review January 17, 2025 10:28
@Lucas-C
Copy link
Member Author

Lucas-C commented Jan 17, 2025

I think this is ready to be merged.

We could improve the documentation on fpdf2 internals later on.
This PR only aims to initiate a dedicated page.

@andersonhc, @gmischler: would you like to review this PR before? 🙂

@Lucas-C Lucas-C force-pushed the docs-on-fpdf2-internals branch from f8ae2b2 to 66c9211 Compare January 17, 2025 10:30
@Lucas-C Lucas-C force-pushed the docs-on-fpdf2-internals branch from 66c9211 to b5f51d0 Compare January 17, 2025 13:45
@Lucas-C Lucas-C force-pushed the docs-on-fpdf2-internals branch from b5f51d0 to b915f60 Compare January 17, 2025 14:03
@Lucas-C Lucas-C merged commit bb3aaa1 into master Jan 17, 2025
18 checks passed
@Lucas-C Lucas-C deleted the docs-on-fpdf2-internals branch January 17, 2025 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants