Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAINT: Bump actions/checkout from 3 to 4 #88

Merged
merged 1 commit into from
Dec 16, 2024

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Dec 9, 2024

Bumps actions/checkout from 3 to 4.

Release notes

Sourced from actions/checkout's releases.

v4.0.0

What's Changed

New Contributors

Full Changelog: actions/checkout@v3...v4.0.0

v3.6.0

What's Changed

New Contributors

Full Changelog: actions/checkout@v3.5.3...v3.6.0

v3.5.3

What's Changed

New Contributors

Full Changelog: actions/checkout@v3...v3.5.3

v3.5.2

What's Changed

Full Changelog: actions/checkout@v3.5.1...v3.5.2

v3.5.1

What's Changed

New Contributors

... (truncated)

Changelog

Sourced from actions/checkout's changelog.

Changelog

v4.2.2

v4.2.1

v4.2.0

v4.1.7

v4.1.6

v4.1.5

v4.1.4

v4.1.3

v4.1.2

v4.1.1

v4.1.0

... (truncated)

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [actions/checkout](https://github.com/actions/checkout) from 3 to 4.
- [Release notes](https://github.com/actions/checkout/releases)
- [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md)
- [Commits](actions/checkout@v3...v4)

---
updated-dependencies:
- dependency-name: actions/checkout
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot added the dependencies Pull requests that update a dependency file label Dec 9, 2024
@Lucas-C Lucas-C changed the title Bump actions/checkout from 3 to 4 MAINT: Bump actions/checkout from 3 to 4 Dec 16, 2024
@Lucas-C
Copy link
Member

Lucas-C commented Dec 16, 2024

The current GitHub Actions pipeline failure on this PR is a typical case where the check added in PR #79 is a bit constraining...

Dependabot is a very useful tool, but does not follow our naming conventions when naming PRs.

I renamed the PR, and re-triggered the pipeline job, but the check still fails!
https://github.com/py-pdf/pdfly/actions/runs/12241329197/job/34469247745

I opened PR #89 as a potential solution.
Once it's merged, Dependabot will rebase this PR on the main branch, and the problem should be solved.

What do you think about this @MartinThoma?

@Lucas-C
Copy link
Member

Lucas-C commented Dec 16, 2024

I renamed the PR, and re-triggered the pipeline job, but the check still fails!
py-pdf/pdfly/actions/runs/12241329197/job/34469247745

Oh, interesting: it seems that Dependabot detected the PR title change, and relaunched another pipeline execution, that succeeded this time:
https://github.com/py-pdf/pdfly/actions/runs/12352364172?pr=88

I'm merging this PR then!

@Lucas-C Lucas-C merged commit d9b111d into main Dec 16, 2024
10 of 11 checks passed
@Lucas-C Lucas-C deleted the dependabot/github_actions/actions/checkout-4 branch December 16, 2024 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant