-
Notifications
You must be signed in to change notification settings - Fork 197
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add two variants of the KCI test #202
Conversation
Signed-off-by: Oliver Schacht <[email protected]>
Signed-off-by: Oliver Schacht <[email protected]>
Signed-off-by: Oliver Schacht <[email protected]>
Signed-off-by: Oliver Schacht <[email protected]>
Signed-off-by: Oliver Schacht <[email protected]>
Signed-off-by: Oliver Schacht <[email protected]>
Signed-off-by: Oliver Schacht <[email protected]>
Signed-off-by: Oliver Schacht <[email protected]>
Signed-off-by: Oliver Schacht <[email protected]>
Signed-off-by: Oliver Schacht <[email protected]>
Signed-off-by: Oliver Schacht <[email protected]>
Signed-off-by: Oliver Schacht <[email protected]>
Signed-off-by: Oliver Schacht <[email protected]>
Signed-off-by: Oliver Schacht <[email protected]>
Signed-off-by: Oliver Schacht <[email protected]>
Hi @OliverSchacht thanks for your amazing contribution! I will review this PR within next week. |
Dear @OliverSchacht I really appreciate this contribution! I reviewed the codes and the logic seems good to me. I didn't identify major running issues. The two unittests passed from my end, though I didn't do other accuracy benchmarks (e.g, those in (One minor point is that I see For now I think this pr is ready to be merged. One suggestion: could you please also add documents to https://github.com/py-why/causal-learn/tree/main/docs/source/independence_tests_index, with general instructions on using FastKCI and RCIT, with parameter choices on e.g., Thank you again :) |
Hi @OliverSchacht , thanks so much for your contribution! When you think it is ready, could you please write a short document as @MarkDana suggested? This would be very helpful for our users to start using this excellent test. |
This PR is updating #201 so it should be easier to merge.
Original Text:
I am adding two variants of the kernel-based conditional independence test, that are aiming at improved computational efficiency.
Namely:
I also added two easy unit tests checking the implementation.
I added the algorithms to the cit class, so they can be used with the PC algorithm for causal discovery.
Happy to hear your feedback!