-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Try to inject parameter value if default value is None #110
Conversation
CodSpeed Performance ReportMerging #110 will not alter performanceComparing Summary
|
it looks like codecov@v3 is broken. Maybe we should add combine steep for codecov? |
thanks @Czaki, I added a test. uses: ./.github/workflows/reusable_coverage_upload.yml
secrets:
codecov_token: ${{ secrets.CODECOV_TOKEN }} but for some reason it's working there but not here. (note that I currently use |
We do not do this. Codecov fixed their action and version 4 allow tokenless upload from a fork of public repository. However time to time we hit api response problems. Because of this we upload coverage in separate steep. |
oh! well that's exciting. somehow I missed this important detail 😂 that's great. |
It was fixed a few months after v4 release |
thanks. yeah, it's all working fine now. I just removed the codecov v3 fallback logic from the reusable workflow and it just does the right thing for PRs from forks |
Currently, in-n-out do not allow injecting parameters for function with default value. This does not allow creating an action that has optional injection but will not crash on injection failure.
A workaround for this may be modifying the signature of the implementation to remove the default value information from the signature. But it is really hacky.
Alternative to this, PR may define a special generic type to inform that injection should be performed even if a default value is provided.