Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Add note on dependency injection when default given #99

Merged
merged 1 commit into from
Dec 18, 2023

Conversation

lucyleeow
Copy link
Contributor

Follow on from #98

Copy link

codecov bot commented Dec 17, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (2044fb3) 100.00% compared to head (799628a) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##              main       #99   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            5         5           
  Lines          521       521           
=========================================
  Hits           521       521           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

codspeed-hq bot commented Dec 17, 2023

CodSpeed Performance Report

Merging #99 will not alter performance

Comparing lucyleeow:doc_default (799628a) with main (2044fb3)

Summary

✅ 5 untouched benchmarks

Copy link
Member

@tlambert03 tlambert03 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@tlambert03 tlambert03 merged commit f8acaa9 into pyapp-kit:main Dec 18, 2023
22 of 23 checks passed
@lucyleeow lucyleeow deleted the doc_default branch December 18, 2023 00:15
@tlambert03 tlambert03 added the documentation Improvements or additions to documentation label Mar 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants