fix: Fix parent attribute to point to proper magicgui widget parent #583
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #583 +/- ##
==========================================
+ Coverage 87.60% 87.64% +0.03%
==========================================
Files 39 39
Lines 4551 4557 +6
==========================================
+ Hits 3987 3994 +7
+ Misses 564 563 -1
☔ View full report in Codecov by Sentry. |
|
Yup, in fact there's an issue about it :) #456 |
brisvag
approved these changes
Sep 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #582
closes #456
This PR fixes
widget.parentbehavior to point to the containing magicguiContainerrather than the backend widget. The implementation is a bit hacky, and currently only works for the qt backend. But it's giving the desired behavior in tests.@brisvag ... I believe this is something we've discussed as well. If you have a moment to take a peek and confirm that this at least moves us in the right direction, I would appreciate it!