Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Support Annotated types in list/tuple #588

Merged
merged 1 commit into from
Oct 4, 2023

Conversation

hanjinliu
Copy link
Collaborator

I found that the annotated type hints such as list[Annotated[...]] and tuple[Annotated[...], ...] were dropped during the process of type resolution, so it was a bit inconsistent to configure ListEdit and TupleEdit.
This PR will fix it.

@codecov
Copy link

codecov bot commented Sep 30, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (e47338a) 87.61% compared to head (41b0794) 87.60%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #588      +/-   ##
==========================================
- Coverage   87.61%   87.60%   -0.01%     
==========================================
  Files          39       39              
  Lines        4538     4551      +13     
==========================================
+ Hits         3976     3987      +11     
- Misses        562      564       +2     
Files Coverage Δ
src/magicgui/widgets/_concrete.py 88.46% <90.47%> (-0.11%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@tlambert03 tlambert03 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @hanjinliu!

@tlambert03 tlambert03 merged commit c11184c into pyapp-kit:main Oct 4, 2023
31 of 32 checks passed
@tlambert03 tlambert03 changed the title Support Annotated types in list/tuple fix: Support Annotated types in list/tuple Oct 20, 2023
@tlambert03 tlambert03 added the bug Something isn't working label Oct 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants