-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MAINT: Add pint as a requirement #592
base: main
Are you sure you want to change the base?
Conversation
hey @larsoner 👋 nice to see you here and thanks for opening a PR. I'm hesitant to add more base level dependencies to magicgui. By its nature, magicgui might potentially support many third party types (beyond pint) but shouldn't require those packages for installation. My assumption with pint was that, if someone wants to provide a widget representation of a Lines 56 to 66 in 21ee452
I see that this means that someone can't immediately run all of the examples without additional installations, but if we add pint, then a similar argument could be made for As an alternative, would you support the addition and of an |
Actually I didn't even notice those options. Maybe just a Just let me know if you agree with how and where these should be documented (or if you have other ideas) and I'm happy to adjust this PR to be a documentation update instead 👍 |
agree! i just tried locally, and mkdocs admonition syntax ( |
(note also: I just killed the antiquated setup.py file in #595 ... so your conflict is due to that. it can just be removed) |
On my system
pip intstall magicgui
followed by running a variant of the "all of these" example from https://pyapp-kit.github.io/magicgui/widgets/#magicgui I got:I guess
pint
is an optional dependency forsuperqt
(?) but it seems likemagicgui
should require it to make sure all examples work out of the box.