Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: use Unpack for better kwargs typing #599

Merged
merged 5 commits into from
Oct 10, 2023

Conversation

tlambert03
Copy link
Member

@tlambert03 tlambert03 commented Oct 10, 2023

this PR uses Unpack to provide nicer static IDE completion for all the places where widget kwargs are passed through a chain of super calls.

These changes have no runtime effects

@codecov
Copy link

codecov bot commented Oct 10, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (2eaa144) 87.68% compared to head (e7e0cef) 87.85%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #599      +/-   ##
==========================================
+ Coverage   87.68%   87.85%   +0.16%     
==========================================
  Files          39       39              
  Lines        4573     4561      -12     
==========================================
- Hits         4010     4007       -3     
+ Misses        563      554       -9     
Files Coverage Δ
src/magicgui/signature.py 96.47% <100.00%> (+0.04%) ⬆️
src/magicgui/type_map/_magicgui.py 96.15% <100.00%> (-0.08%) ⬇️
src/magicgui/widgets/_concrete.py 89.40% <100.00%> (+0.93%) ⬆️
src/magicgui/widgets/_table.py 96.14% <100.00%> (+<0.01%) ⬆️
src/magicgui/widgets/bases/_button_widget.py 100.00% <100.00%> (ø)
src/magicgui/widgets/bases/_categorical_widget.py 80.28% <ø> (ø)
src/magicgui/widgets/bases/_container_widget.py 91.13% <100.00%> (-0.05%) ⬇️
src/magicgui/widgets/bases/_ranged_widget.py 91.73% <100.00%> (+2.67%) ⬆️
src/magicgui/widgets/bases/_slider_widget.py 96.77% <100.00%> (ø)
src/magicgui/widgets/bases/_value_widget.py 98.33% <ø> (ø)
... and 1 more

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tlambert03 tlambert03 changed the title style: use Unpack for kwargs typing style: use Unpack for better kwargs typing Oct 10, 2023
@tlambert03 tlambert03 merged commit 3aa4b81 into pyapp-kit:main Oct 10, 2023
33 checks passed
@tlambert03 tlambert03 deleted the unpack branch October 10, 2023 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant