fix: fix parent_changed signal, and rename to native_parent_changed #628
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #627 by properly including the
widget.native.parent()
as the first argument of the signal.However, that signal name is rather confusing, since
Widget.parent
now mean amagicgui.widgets.Container
(see #582 and #456). So, this PR also renames it asnative_parent_changed
, to make clearer that what the callback will receive is the native object and not a magicgui container parent. (parent_changed
is retained as a deprecated alias).This means that after
widget.native_parent_changed
has been emitted with a non-null value, it is still quite possible thatwidget.parent
will beNone
if it is not inside of a magicgui Container. However,widget.native.parent()
will not be None.cc @aeisenbarth. hope this will help you. let me know if you have any thoughts