-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: fix safe_issubclass for NewType #678
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #678 +/- ##
==========================================
- Coverage 88.87% 88.85% -0.02%
==========================================
Files 39 39
Lines 4754 4756 +2
==========================================
+ Hits 4225 4226 +1
- Misses 529 530 +1 ☔ View full report in Codecov by Sentry. |
@tlambert03 The #671 changed type annotation used in |
ah, i think these should probably be restored. since |
Thanks! |
Do you need this released asap? Can it wait a week or so to give time for testing the current pre-release? Or would you prefer a cherry pick back-release |
This is a question to @psobolewskiPhD |
I mean it's been around and it only affects things that didn't update to drop older python, so I don't think it's critical? |
Sounds good thanks |
This pull request has been mentioned on Image.sc Forum. There might be relevant details there: https://forum.image.sc/t/help-with-napari-unicell-plugin/105331/15 |
Closes napari/napari#7129
Today I learn that such code:
Raises exception instead of returning True.
So this PR is a followup to #665 to fully resolve the upstream napari bug.