-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: better repr for WeakCallback objects #236
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #236 +/- ##
===========================================
- Coverage 100.00% 99.94% -0.06%
===========================================
Files 22 22
Lines 1849 1872 +23
===========================================
+ Hits 1849 1871 +22
- Misses 0 1 +1
☔ View full report in Codecov by Sentry. |
CodSpeed Performance ReportMerging #236 will degrade performances by 22.57%Comparing Summary
Benchmarks breakdown
|
WalkthroughThis pull request introduces changes to improve code clarity and consistency across several Python files. It includes renaming classes and functions, adding new methods for object representation, updating import statements, and modifying CI/CD pipeline steps. The changes are primarily focused on enhancing readability and maintainability. Changes
TipsChat with CodeRabbit Bot (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review Status
Actionable comments generated: 0
Files selected for processing (4)
- benchmarks/_evented.py (1 hunks)
- src/psygnal/_signal.py (6 hunks)
- src/psygnal/_weak_callback.py (18 hunks)
- tests/test_weak_callable.py (1 hunks)
Files skipped from review due to trivial changes (3)
- benchmarks/_evented.py
- src/psygnal/_weak_callback.py
- tests/test_weak_callable.py
Additional comments (Suppressed): 6
src/psygnal/_signal.py (6)
30-38: The import statements have been updated to reflect the new names of classes and functions in
_weak_callback.py
. Ensure that these changes are consistent throughout the codebase.597-603: The
_WeakSetattr
class has been renamed toWeakSetattr
. This change is reflected in the instantiation of aWeakSetattr
object. Make sure all references to this class have been updated accordingly.630-635: The
_WeakSetattr
class has been renamed toWeakSetattr
. This change is reflected in the instantiation of aWeakSetattr
object. Make sure all references to this class have been updated accordingly.701-707: The
_WeakSetitem
class has been renamed toWeakSetitem
. This change is reflected in the instantiation of aWeakSetitem
object. Make sure all references to this class have been updated accordingly.738-742: The
_WeakSetitem
class has been renamed toWeakSetitem
. This change is reflected in the instantiation of aWeakSetitem
object. Make sure all references to this class have been updated accordingly.1124-1130: The
_StrongFunction
class has been renamed toStrongFunction
. This change is reflected in the filtering of the_slots
attribute. Make sure all references to this class have been updated accordingly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
for easier debugging
Summary by CodeRabbit
src/psygnal/_signal.py
andsrc/psygnal/_weak_callback.py
for improved consistency and clarity.object_repr()
method to theWeakCallback
class insrc/psygnal/_weak_callback.py
to provide a human-readable representation of an object.tests/test_weak_callable.py
for better debugging during testing..github/workflows/test.yml
to run tests using a headless GUI, improving test coverage.