Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: make SignalGroupDescriptor generic #297

Open
wants to merge 10 commits into
base: main
Choose a base branch
from

remove future

c49d246
Select commit
Loading
Failed to load commit list.
Open

feat: make SignalGroupDescriptor generic #297

remove future
c49d246
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project failed Mar 11, 2024 in 1s

99.94% (-0.06%) compared to f37c26f

View this Pull Request on Codecov

99.94% (-0.06%) compared to f37c26f

Details

Codecov Report

Attention: Patch coverage is 96.55172% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 99.94%. Comparing base (f37c26f) to head (c49d246).

❗ Current head c49d246 differs from pull request most recent head 43c6e16. Consider uploading reports for the commit 43c6e16 to get more accurate results

Files Patch % Lines
src/psygnal/_group_descriptor.py 96.15% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##              main     #291      +/-   ##
===========================================
- Coverage   100.00%   99.94%   -0.06%     
===========================================
  Files           22       22              
  Lines         1973     1988      +15     
===========================================
+ Hits          1973     1987      +14     
- Misses           0        1       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.