Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: make Signal and SignalInstance Generic, support static type validation of signal connections #304

Open
wants to merge 17 commits into
base: main
Choose a base branch
from

Merge branch 'main' into generic-signal

cdb2ec3
Select commit
Loading
Failed to load commit list.
Open

feat: make Signal and SignalInstance Generic, support static type validation of signal connections #304

Merge branch 'main' into generic-signal
cdb2ec3
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project failed Nov 4, 2024 in 0s

99.95% (-0.05%) compared to 019232e

View this Pull Request on Codecov

99.95% (-0.05%) compared to 019232e

Details

Codecov Report

Attention: Patch coverage is 96.77419% with 1 line in your changes missing coverage. Please review.

Project coverage is 99.95%. Comparing base (019232e) to head (cdb2ec3).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
src/psygnal/_signal.py 96.15% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##              main     #304      +/-   ##
===========================================
- Coverage   100.00%   99.95%   -0.05%     
===========================================
  Files           21       21              
  Lines         2062     2089      +27     
===========================================
+ Hits          2062     2088      +26     
- Misses           0        1       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.