Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: improve paint time for QColormapLineEdit #245

Merged
merged 2 commits into from
May 12, 2024

Conversation

tlambert03
Copy link
Member

small PR that improves the time-to-paint performance of QColormapLineEdit (which is used in the cmap combobox).

@tlambert03 tlambert03 changed the title perf: improve paint time for cmapLineEdit perf: improve paint time for QColormapLineEdit May 12, 2024
@tlambert03 tlambert03 added the refactor Code reorganization label May 12, 2024
Copy link

codecov bot commented May 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.12%. Comparing base (4a0aaca) to head (56c517f).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #245      +/-   ##
==========================================
+ Coverage   87.11%   87.12%   +0.01%     
==========================================
  Files          46       46              
  Lines        3398     3403       +5     
==========================================
+ Hits         2960     2965       +5     
  Misses        438      438              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tlambert03 tlambert03 merged commit 8f62b0b into pyapp-kit:main May 12, 2024
48 checks passed
@tlambert03 tlambert03 deleted the perf-cmap branch May 12, 2024 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor Code reorganization
Development

Successfully merging this pull request may close these issues.

1 participant