Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: better warning for download error #266

Merged
merged 1 commit into from
Dec 14, 2024

Conversation

tlambert03
Copy link
Member

slightly more informative error when failing to download an iconify icon

Copy link

codecov bot commented Dec 14, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 86.97%. Comparing base (34b9851) to head (82f3cb4).
Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
src/superqt/iconify/__init__.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #266   +/-   ##
=======================================
  Coverage   86.97%   86.97%           
=======================================
  Files          46       46           
  Lines        3439     3439           
=======================================
  Hits         2991     2991           
  Misses        448      448           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tlambert03 tlambert03 merged commit e471031 into pyapp-kit:main Dec 14, 2024
42 of 43 checks passed
@tlambert03 tlambert03 deleted the better-warn branch December 14, 2024 20:29
@tlambert03 tlambert03 added the bug Something isn't working label Jan 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Development

Successfully merging this pull request may close these issues.

1 participant