bricks/_common/mpconfigport: enable unicode support #271
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Will this have any effect on functions or methods that currently accept both bytes and strings? (I have not looked into this yet, just wondering). |
No, anything that accepts both would be using the buffer protocol, so nothing would change there. |
|
This would be too big for Technic Hub at the moment. Since Prime Hub does seem to gradually become the most popular hub, I suppose we could add a level above |
laurensvalk
force-pushed
the
unicode
branch
2 times, most recently
from
48d405a to
47bb9a7
Compare
Allows for additional features to be grouped as LEVEL2 on hubs with more space.
Enable MICROPY_PY_BUILTINS_STR_UNICODE on hubs with PYBRICKS_OPT_EXTRA_LEVEL2. Without this, there is not any difference between str and bytes, which can make it hard to work with multi-byte characters.
|
Merged and enabled on hubs with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable
MICROPY_PY_BUILTINS_STR_UNICODEon hubs withPYBRICKS_OPT_EXTRA_MOD.Without this, there is not any difference between str and bytes, which can make it hard to work with multi-byte characters.
This takes up about 1700 bytes on Technic hub.
Related discussion: https://github.com/orgs/pybricks/discussions/1882#discussioncomment-10962184