pybricks.ev3devices.ColorSensor: Use blocking read calls #273
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Other EV3 sensors in this module use the pb_type_device_get_data_blocking() method. I think that using pb_type_device_get_data() as it is used (only) in the color sensor class the sensor will not work for reading non-default modes. Fixes: 8a52c95 ("pbdrv/legodev: Refactor LEGO device abstraction.")
|
Thank you. The EV3 build hasn't been tested much lately, and won't be continued in its current form. The We're currently working on a bare metal version of Pybricks for EV3. It will probably get a rewrite of It will use the same |
|
Oh, I see. In that case, feel free to close this PR. |
|
I think we can still merge it to make sure the legacy EV3 version is still complete. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Other EV3 sensors in this module use the
pb_type_device_get_data_blocking()method. I think that usingpb_type_device_get_data()as it is used (only) in the color sensor class the sensor will not work for reading non-default modes.I have found this by accident - I wanted to know if Pybricks waits for a sensor to change its mode. I think this is what happens for most EV3 sensors and it is only disabled for the EV3 color sensor.
However, I unfortunately have no way to test this and also I'm not entirely sure the bug is there.