pybricks.common.Speaker: fix negative duration in beep() #279
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Return immediately if duration is negative as per documentation. This works the same as with motor methods, with `wait=False` in that the method is not awaitable when duration is negative. Issue: pybricks/support#1996
|
Tested with: from pybricks.hubs import PrimeHub
from pybricks.tools import wait
hub = PrimeHub()
while True:
hub.speaker.beep(100, -1)
wait(100)
hub.speaker.beep(0, -1)
wait(100) |
|
Thank you! This looks good. Can you also test it with an async program? |
|
Works with async like this: from pybricks.hubs import PrimeHub
from pybricks.tools import wait, run_task
hub = PrimeHub()
async def main():
while True:
hub.speaker.beep(100, -1)
await wait(100)
hub.speaker.beep(0, -1)
await wait(100)
run_task(main()) |
|
Thank you! |
|
Thanks for quick resolving the issue! |
|
@czuryk If you want to try the fix, you can do so with these instructions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Return immediately if duration is negative as per documentation.
This works the same as with motor methods, with
wait=Falsein that the method is not awaitable when duration is negative.Issue: pybricks/support#1996