Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow sub-class certificate #12077

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Allow sub-class certificate #12077

wants to merge 1 commit into from

Conversation

alex
Copy link
Member

@alex alex commented Nov 29, 2024

This is to enable folks who previously subclassed teh ABC to persist

This is to enable folks who previously subclassed teh ABC to persist
@alex alex mentioned this pull request Nov 29, 2024
@reaperhulk
Copy link
Member

Should we allow subclassing on all of them or wait for users to request?

If we consider subclassing officially part of our public surface we should add a test that simply subclasses without an exception with a small comment explaining why.

@alex
Copy link
Member Author

alex commented Nov 29, 2024

I suppose it's a begrudgingly supported part of our API surface. I'll add a test. No reason to extend it further though.

@alex
Copy link
Member Author

alex commented Nov 29, 2024

It's a good thing you told me to add a test. While subclassing now works, it's not actually possible to instantiate an instance of this AFAICT.

@alex
Copy link
Member Author

alex commented Nov 29, 2024

I'm not sure what the correct way to proceed is, as we don't want these to be instantiable normally.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants