Support for copying private keys #12110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alex
reviewed
Dec 6, 2024
|
I think it's fine to load a weak key and skip on FIPS and be marginally faster. |
|
Thanks, I reverted back to loading the key from a file and added a I also added abstract methods to the abstract base classes. The ABCs for the public keys were also missing the abstract version of the |
alex
approved these changes
Dec 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for copying private keys, such as the RSAPrivateKey. This resolves issue #11859.
Wasn't sure if it was better to generate a stronger key for
DHPrivateKeyin the tests or to load a smaller one from a file and use@pytest.mark.skip_fips(reason="non-FIPS parameters")to get it to pass on FIPS; settled for the first option, to have better test coverage in exchange of speed, but let me know if you'd prefer it the other way around. UPDATE: Based on feedback in the review changed to loading the key from a file and using skip_fips for that test.