Release v2.4.1 (#617)

CHANGELOG.md

@@ -1,5 +1,9 @@
 # Release Notes
 
+## [v2.4.1] (2024-11-21)
+
+* Allow new context argument of metric instrument methods to be passed positionally by @alexmojaki in [#616](https://github.com/pydantic/logfire/pull/616)
+
 ## [v2.4.0] (2024-11-20)
 
 * Support `logfire.instrument` without arguments by @Kludex in [#607](https://github.com/pydantic/logfire/pull/607)
@@ -434,3 +438,4 @@ First release from new repo!
 [v2.2.1]: https://github.com/pydantic/logfire/compare/v2.2.0...v2.2.1
 [v2.3.0]: https://github.com/pydantic/logfire/compare/v2.2.1...v2.3.0
 [v2.4.0]: https://github.com/pydantic/logfire/compare/v2.3.0...v2.4.0
+[v2.4.1]: https://github.com/pydantic/logfire/compare/v2.4.0...v2.4.1

logfire-api/logfire_api/_internal/metrics.pyi

@@ -1,12 +1,10 @@
 import dataclasses
 from _typeshed import Incomplete
 from abc import ABC
-from opentelemetry.context import Context
 from opentelemetry.metrics import CallbackT as CallbackT, Counter, Histogram, Instrument, Meter, MeterProvider, ObservableCounter, ObservableGauge, ObservableUpDownCounter, UpDownCounter, _Gauge
 from opentelemetry.util.types import Attributes
 from threading import Lock
-from typing import Any, Generic, Sequence, TypeVar, TypedDict
-from typing_extensions import Unpack
+from typing import Any, Generic, Sequence, TypeVar
 from weakref import WeakSet
 
 Gauge: Incomplete
@@ -38,15 +36,6 @@ class _ProxyMeter(Meter):
     def create_observable_up_down_counter(self, name: str, callbacks: Sequence[CallbackT] | None = None, unit: str = '', description: str = '') -> ObservableUpDownCounter: ...
 InstrumentT = TypeVar('InstrumentT', bound=Instrument)
 
-class MaybeContext(TypedDict, total=False):
-    """Backward-compatible keyword arguments for methods like `Counter.add`.
-
-    Starting with opentelemetry-sdk 1.28.0, these methods accept an additional optional `context` argument.
-    This is passed to the underlying instrument using `**kwargs` for compatibility with older versions.
-    This is the type hint for those kwargs.
-    """
-    context: Context | None
-
 class _ProxyInstrument(ABC, Generic[InstrumentT]):
     def __init__(self, instrument: InstrumentT, name: str, unit: str, description: str) -> None: ...
     def on_meter_set(self, meter: Meter) -> None:
@@ -56,17 +45,17 @@ class _ProxyAsynchronousInstrument(_ProxyInstrument[InstrumentT], ABC):
     def __init__(self, instrument: InstrumentT, name: str, callbacks: Sequence[CallbackT] | None, unit: str, description: str) -> None: ...
 
 class _ProxyCounter(_ProxyInstrument[Counter], Counter):
-    def add(self, amount: int | float, attributes: Attributes | None = None, **kwargs: Unpack[MaybeContext]) -> None: ...
+    def add(self, amount: int | float, attributes: Attributes | None = None, *args: Any, **kwargs: Any) -> None: ...
 
 class _ProxyHistogram(_ProxyInstrument[Histogram], Histogram):
-    def record(self, amount: int | float, attributes: Attributes | None = None, **kwargs: Unpack[MaybeContext]) -> None: ...
+    def record(self, amount: int | float, attributes: Attributes | None = None, *args: Any, **kwargs: Any) -> None: ...
 
 class _ProxyObservableCounter(_ProxyAsynchronousInstrument[ObservableCounter], ObservableCounter): ...
 class _ProxyObservableGauge(_ProxyAsynchronousInstrument[ObservableGauge], ObservableGauge): ...
 class _ProxyObservableUpDownCounter(_ProxyAsynchronousInstrument[ObservableUpDownCounter], ObservableUpDownCounter): ...
 
 class _ProxyUpDownCounter(_ProxyInstrument[UpDownCounter], UpDownCounter):
-    def add(self, amount: int | float, attributes: Attributes | None = None, **kwargs: Unpack[MaybeContext]) -> None: ...
+    def add(self, amount: int | float, attributes: Attributes | None = None, *args: Any, **kwargs: Any) -> None: ...
 
 class _ProxyGauge(_ProxyInstrument[Gauge], Gauge):
-    def set(self, amount: int | float, attributes: Attributes | None = None, **kwargs: Unpack[MaybeContext]) -> None: ...
+    def set(self, amount: int | float, attributes: Attributes | None = None, *args: Any, **kwargs: Any) -> None: ...

logfire-api/pyproject.toml

@@ -4,7 +4,7 @@ build-backend = "hatchling.build"
 
 [project]
 name = "logfire-api"
-version = "2.4.0"
+version = "2.4.1"
 description = "Shim for the Logfire SDK which does nothing unless Logfire is installed"
 authors = [
     { name = "Pydantic Team", email = "[email protected]" },

pyproject.toml

@@ -4,7 +4,7 @@ build-backend = "hatchling.build"
 
 [project]
 name = "logfire"
-version = "2.4.0"
+version = "2.4.1"
 description = "The best Python observability tool! 🪵🔥"
 requires-python = ">=3.8"
 authors = [