Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

supports-parallel-tools param to OpenAI #821

Closed
wants to merge 1 commit into from

Conversation

Dirt-Nasty
Copy link

Added supports-parallel-tools param to OpenAIModel for models that do not support passing this in. ex (Azure Open AI)

… not support passing this in. ex (Azure Open AI)
@github-actions github-actions bot temporarily deployed to deploy-preview January 30, 2025 20:16 Inactive
@sydney-runkle
Copy link
Member

Hmm, I think you can just use parallel_tool_calls in ModelSettings to control this as desired.

@Dirt-Nasty
Copy link
Author

@sydney-runkle

There is a difference.

Setting it in ModelSettings as False still executes chat.completions.create with the parallel_tools_calls as False resulting in.

BadRequestError: Error code: 400 - {'error_code': 'BAD_REQUEST', 'message': 'Bad request: json: unknown field "parallel_tool_calls"\n'}

Some models do not accept that.

As an example any model being deployed with MLFlow using 'llm/v1/chat` does not accept that value in the model schema.

https://mlflow.org/docs/latest/llms/deployments/index.html#standard-deployments-parameters
https://github.com/Azure/azure-rest-api-specs/blob/main/specification/cognitiveservices/data-plane/AzureOpenAI/inference/preview/2024-05-01-preview/generated.json

If I were to call an Agent without ModelSettings and tools then I can query my model just fine.

Thats because NOT_GIVEN is being used in that case which omits it from being passed to the function altogether.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants