feat: add S3Path #206
Merged
feat: add S3Path #206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #206 +/- ##
==========================================
Coverage 100.00% 100.00%
==========================================
Files 11 18 +7
Lines 685 1021 +336
Branches 169 246 +77
==========================================
+ Hits 685 1021 +336 ☔ View full report in Codecov by Sentry. |
yezz123
reviewed
Sep 2, 2024
There was a problem hiding this comment.
Good Start @lucianosrp
Two things missing:
- I added a comment about docstring.
- You should add JSON schema tests here https://github.com/pydantic/pydantic-extra-types/blob/main/tests/test_json_schema.py
Overall once this is done, I will be happy to merge it 🤗
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not 100% if this was already made somewhere.
Very simple s3 path parser but can still come in handy!
Please let me know your thoughts. Feedback is always welcomed 🤗