Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Right navbar column skips the section clicked #1965

Open
dylanh724 opened this issue Aug 22, 2024 · 7 comments
Open

Right navbar column skips the section clicked #1965

dylanh724 opened this issue Aug 22, 2024 · 7 comments
Labels
kind: bug Something isn't working needs: investigation Someone in the team needs to investigate and try and reproduce this issue needs: more information Needs more information from the author before we can move forward

Comments

@dylanh724
Copy link

dylanh724 commented Aug 22, 2024

This was originally reported for sphinx-book-theme that seems to also have this bug on their own docs site (but, iirc, their main theme comes from this repo). See a full report with GIFs and links here:

executablebooks/sphinx-book-theme#853

Or repro the bug yourself here on your own docs:

https://pydata-sphinx-theme.readthedocs.io/en/stable/examples/kitchen-sink/admonitions.html#attention

  1. On the right column, click a header in the middle
  2. Now click the header +1 up. It will land on +2 up.

Edited by @trallard to copy content from the original issue in the executablebooks repo

context
When I click a right column child header, it skips to the section above or below my cursor and awkwardly highlights the incorrect section:

expectation
When I click on a header anchor link on the right column nav, I expect it to go straight there and highlight the correctly selected link.

@electric-coder
Copy link

I confirm this happens using Firefox 129.0.1 (64-bit) on Windows 10.

I had noticed this before but didn't bother reporting.

@dbitouze
Copy link
Contributor

I don't confirm this using Firefox 129.0.2 (64 bits) on GNU/Linux.

@ramevaf
Copy link

ramevaf commented Sep 2, 2024

Could this be related to Issue #1889 ?

@dylanh724
Copy link
Author

Could this be related to Issue #1889 ?

Very possible!

@trallard
Copy link
Collaborator

trallard commented Sep 3, 2024

@dylanh724 or @electric-coder, what version of the PyData Sphinx Theme are you using?

I can see the behaviour on the admonition page as reported in #1965 (comment), but I cannot reproduce this on other pages (I tried various within the user and community guides in our docs in dev and 0.15.4, see the video below)

Sep-03-2024.15-12-31.mp4

@gabalafou have you seen this before?

Could this be related to Issue #1889 ?

This should be unrelated to the above issue tho.

@trallard trallard added needs: more information Needs more information from the author before we can move forward needs: investigation Someone in the team needs to investigate and try and reproduce this issue kind: bug Something isn't working labels Sep 3, 2024
@nishikantparmariam
Copy link

JFYI: Another reproducer: #2053 (comment)

@dylanh724
Copy link
Author

dylanh724 commented Nov 26, 2024

@dylanh724 or @electric-coder, what version of the PyData Sphinx Theme are you using?

I'm using sphinx-book-theme 1.1.3 (forks off from this theme - and since it happens with your docs, it doesn't seem to be the spinoff theme bug)

I wonder if this only happens with nested headers? Unfortunately, I'm out of time to test further - but hope this helps.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind: bug Something isn't working needs: investigation Someone in the team needs to investigate and try and reproduce this issue needs: more information Needs more information from the author before we can move forward
Projects
None yet
Development

No branches or pull requests

6 participants