-
Notifications
You must be signed in to change notification settings - Fork 327
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reposition the admonition title icon to the top of the paragraph in m… #2100
base: main
Are you sure you want to change the base?
Reposition the admonition title icon to the top of the paragraph in m… #2100
Conversation
…ulti-line titles Fixes pydata#2099
See #2101 for RTD build failure issue. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this LGTM, ping @gabalafou for affirmation that hard coding 0.5rem is the right call here (IDK if we have a variable we should use instead, or if there's a cleverer way to align this icon to the top text line)
@drammock, yes it would be better to make the admonition title bar a flex box and to align the icon with the text that way - i.e.: display: flex;
flex-direction: row;
align-content: baseline; But to do that we would need to refactor the admonition CSS. This is probably something we should do because right now I think that it's a bit overly complicated. For example, the container has horizontal padding that the title element has to offset with negative margins. That suggests to me that there's almost certainly a cleaner, simpler way to structure our admonition styles. But that's a bigger, longer fix. For now, setting the |
a11y failures seem unrelated, but happened again after restarting the job, so seems like maybe not a transient network problem:
and
@trallard what is your feeling about merging with red CIs? In my other projects I'd pause this PR until the CIs are fixed elsewhere, then merge main into this one to get CIs green. But approaches differ and I forget if we have a policy. |
I just ran the accessibility tests locally ( |
…ulti-line titles
Fixes #2099