Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cast numpy scalars to arrays in NamedArray.from_array #10008

Merged
merged 5 commits into from
Jan 30, 2025
Merged

cast numpy scalars to arrays in NamedArray.from_array #10008

merged 5 commits into from
Jan 30, 2025

Conversation

keewis
Copy link
Collaborator

@keewis keewis commented Jan 30, 2025 •
edited by kmuehlbauer
Loading

cc @kmuehlbauer

@kmuehlbauer
Copy link
Contributor

Toggling CI

@kmuehlbauer kmuehlbauer reopened this Jan 30, 2025
@kmuehlbauer
Copy link
Contributor

@keewis The [skip-ci] prevents the CI from running. And the other runs haven been canceled by this commit. Can you push another commit to get CI running again?

@kmuehlbauer kmuehlbauer mentioned this pull request Jan 30, 2025
Closed
@kmuehlbauer
Copy link
Contributor

@keewis mypy is complaining about some:

xarray/tests/test_namedarray.py: note: In member "test_aggregation" of class "TestNamedArray":
xarray/tests/test_namedarray.py:595: error: Need type annotation for "x"  [var-annotated]

The other two mypy issues are handled by #10006

@kmuehlbauer
Copy link
Contributor

Thanks so much @keewis for looking into this! The doctest is fixed! I've followed the suggestion from mypy and added a type-hint.

@keewis
Copy link
Collaborator Author

keewis commented Jan 30, 2025

the failing mypy CI (unused ignores) is unrelated, so let's merge this

@keewis keewis merged commit f91306a into pydata:main Jan 30, 2025
27 of 29 checks passed
@keewis keewis deleted the namedarray-numpy2.1 branch January 30, 2025 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kmuehlbauer kmuehlbauer kmuehlbauer left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Doctest failing with numpy 2.1.3
2 participants
@keewis @kmuehlbauer