Integrate and modify utils module from PygameCommunityBot, add initialization code and config helper module
#3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…and events module
Mega-JC
changed the title
events and utils modules, add initialization code and config fileevents and utils modules from PygameCommunityBot, add initialization code and config file
ankith26
reviewed
Mar 18, 2022
| ) | ||
|
|
||
| if config.client is None: | ||
| config.client = client |
There was a problem hiding this comment.
the bit of code above this line in this function seems to be repeated here and also in utils. How about extracting this functionality into something like _init()
There was a problem hiding this comment.
This is intentional, splitting off this two-liner into a separate function would increase code complexity for a small gain IMO. I admit that it is repetitive, but it feels easier to reason about this way.
Mega-JC
changed the title
events and utils modules from PygameCommunityBot, add initialization code and config fileutils module from PygameCommunityBot, add initialization code and config helper module
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can squash merge this one.