Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TST] Compat with macos and window, FailedHealthCheck #1189

Merged

Conversation

Zeroto521
Copy link
Member

@Zeroto521 Zeroto521 commented Nov 3, 2022

PR Description

Please describe the changes proposed in the pull request:

Add @settings(deadline=None) decorator to compat testing on macos and window

This PR resolves #1181.

PR Checklist

Please ensure that you have done the following:

  1. PR in from a fork off your branch. Do not PR from <your_username>:dev, but rather from <your_username>:<feature-branch_name>.
  1. If you're not on the contributors list, add yourself to AUTHORS.md.
  1. Add a line to CHANGELOG.md under the latest version header (i.e. the one that is "on deck") describing the contribution.
    • Do use some discretion here; if there are multiple PRs that are related, keep them in a single line.

Automatic checks

There will be automatic checks run on the PR. These include:

  • Building a preview of the docs on Netlify
  • Automatically linting the code
  • Making sure the code is documented
  • Making sure that all tests are passed
  • Making sure that code coverage doesn't go down.

Relevant Reviewers

Please tag maintainers to review.

@Zeroto521
Copy link
Member Author

Well, It's hard to say. Sometimes, all envs can pass the health check, and sometimes can't.
It seems all test cases with @given need to disable the health check.

Originally posted by @Zeroto521 in #1143 (comment)

@codecov
Copy link

codecov bot commented Nov 3, 2022

Codecov Report

Merging #1189 (97a5c17) into dev (9c02ab8) will increase coverage by 50.40%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##              dev    #1189       +/-   ##
===========================================
+ Coverage   47.30%   97.70%   +50.40%     
===========================================
  Files          76       76               
  Lines        3482     3482               
===========================================
+ Hits         1647     3402     +1755     
+ Misses       1835       80     -1755     

@ericmjl
Copy link
Member

ericmjl commented Nov 3, 2022

LGTM. Gonna hit merge!

@ericmjl ericmjl merged commit 598d1a3 into pyjanitor-devs:dev Nov 3, 2022
samukweku pushed a commit that referenced this pull request Nov 28, 2022
* fix `hypothesis.errors.FailedHealthCheck`

* fix `hypothesis.errors.FailedHealthCheck`

* fix `hypothesis.errors.FailedHealthCheck`

* fix `hypothesis.errors.FailedHealthCheck`

* fix `hypothesis.errors.FailedHealthCheck`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[TST] Compat with macos and window, FailedHealthCheck
2 participants