-
Notifications
You must be signed in to change notification settings - Fork 172
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ENH]row_to_names
for polars
#1363
Conversation
🚀 Deployed on https://deploy-preview-1363--pyjanitor.netlify.app |
@samukweku it looks like this one also needs to have merge conflicts resolved before we can continue. Would you be kind enough to take a look at it please? |
@samukweku it looks like merging other polars dataframe functions results in large merge conflicts, which may make further development on the Do you think there is a way to leverage the polars API to create a I tried thinking of a few other strategies, but none of them seem satisfactory. This included dynamically monkey-patching the docstrings of the PolarsFrame class methods from the underlying implementation function. But that has problems, just like other ideas I thought of, and didn't seem satisfactory. |
@ericmjl i thought of going with the pandas_flavor format but decided against it (polars has three namespaces which we support - lazyframe, expr and eager frames - it would be an issue in the docs rendering for these namespaces) - so i chose another route, creating 3 files for each of the namespaces. Still not sure if this is good enough - hopefully there is a better way. or maybe there is a better way to modify pandas_flavor to better support the namespaces? |
@samukweku that's a good point, I didn't think of that. |
PR Description
Please describe the changes proposed in the pull request:
row_to_names
method for polars**This PR relates to #1352 **
PR Checklist
Please ensure that you have done the following:
<your_username>
:dev
, but rather from<your_username>
:<feature-branch_name>
.AUTHORS.md
.CHANGELOG.md
under the latest version header (i.e. the one that is "on deck") describing the contribution.Automatic checks
There will be automatic checks run on the PR. These include:
Relevant Reviewers
Please tag maintainers to review.