[ENH] maintain sorted array for conditional join #1398
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 15 commits
September 7, 2024 09:16
|
🚀 Deployed on https://deploy-preview-1398--pyjanitor.netlify.app |
added 2 commits
September 7, 2024 23:34
samukweku
changed the title
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #1398 +/- ##
==========================================
- Coverage 89.07% 83.72% -5.35%
==========================================
Files 87 87
Lines 5374 5857 +483
==========================================
+ Hits 4787 4904 +117
- Misses 587 953 +366 |
samukweku
force-pushed
the
samukweku/non-equi-join-improve
branch
from
dc4357c to
af7ef10
Compare
samukweku
force-pushed
the
samukweku/non-equi-join-improve
branch
from
af7ef10 to
cc66145
Compare
ericmjl
approved these changes
Oct 2, 2024
There was a problem hiding this comment.
Wow, this one is a big PR to review. @samukweku I definitely haven't been able to find a good chunk of time to review it in detail. I'm gonna approve it knowing that the tests pass, and that's possibly the best I can do for now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the third part of a series of PRs that ultimately adds support for aggregations within
conditional_join. the numba code now uses an array that is kept sorted, based on grantjenks' sortedcontainers implementation. In one case, perf. improved by about 50x compared to the current implementation; too large a perf diff?PR Description
Please describe the changes proposed in the pull request:
dforrightis emptyThis PR relates to #1269, #1396 and #1397 .
Please tag maintainers to review.