Skip to content

Commit

Permalink
Deprecation of node < v18
Browse files Browse the repository at this point in the history
- Deprecate older node engines
- Add node action for github workflows
- Update to publish action to use node v20
  • Loading branch information
exsilium committed Dec 6, 2023
1 parent e057622 commit 8b0edae
Show file tree
Hide file tree
Showing 4 changed files with 57 additions and 19 deletions.
23 changes: 23 additions & 0 deletions .github/workflows/nodejs.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
name: Node CI

on:
push:
branches:
- master

jobs:
build:
runs-on: ubuntu-latest
strategy:
matrix:
node-version: [18.x, 19.x, 20.x, 21.x]
steps:
- uses: actions/checkout@v3
- name: Use Node.js ${{ matrix.node-version }}
uses: actions/setup-node@v3
with:
node-version: ${{ matrix.node-version }}
- name: npm install and test
run: |
npm install
npm test
12 changes: 6 additions & 6 deletions .github/workflows/npm-publish.yml
Original file line number Diff line number Diff line change
Expand Up @@ -11,21 +11,21 @@ jobs:
build:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2
- uses: actions/setup-node@v1
- uses: actions/checkout@v3
- uses: actions/setup-node@v3
with:
node-version: 12
node-version: 20
- run: npm ci
- run: npm test

publish-npm:
needs: build
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2
- uses: actions/setup-node@v1
- uses: actions/checkout@v3
- uses: actions/setup-node@v3
with:
node-version: 12
node-version: 20
registry-url: https://registry.npmjs.org/
- run: npm ci
- run: npm publish
Expand Down
34 changes: 24 additions & 10 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

7 changes: 4 additions & 3 deletions package.json
Original file line number Diff line number Diff line change
@@ -1,10 +1,11 @@
{
"name": "@pylonide/smith",
"version": "0.1.24",
"version": "0.2.0",
"description": "Smith is an RPC agent system for Node.JS used in architect and vfs.",
"author": "Ajax.org B.V. <[email protected]>",
"author": "Sten Feldman <[email protected]>",
"license": "MIT",
"contributors": [
"Ajax.org B.V. <[email protected]>",
{
"name": "Tim Caswell",
"email": "[email protected]>"
Expand All @@ -20,7 +21,7 @@
},
"main": "smith.js",
"engines": {
"node": ">= 12.22.1"
"node": ">= 18.18.2"
},
"dependencies": {
"msgpack-js": "~0.3.0"
Expand Down

0 comments on commit 8b0edae

Please sign in to comment.