Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use local dataset for CLV tests #1412

Merged
merged 1 commit into from
Jan 19, 2025

Conversation

nayan2167
Copy link
Contributor

@nayan2167 nayan2167 commented Jan 19, 2025

Description

  • Modified test_utils.py to use the local CLV dataset instead of downloading from GitHub.
  • Ensured the dataset is included in the repository.

Related Issue

Checklist

Modules affected

  • MMM
  • CLV
  • Customer Choice

Type of change

  • New feature/enhancement
  • Bug fix
  • Documentation
  • Maintenance
  • Other (please specify):

📚 Documentation preview 📚: https://pymc-marketing--1412.org.readthedocs.build/en/1412/

- Modified test_utils.py to use local CLV dataset instead of downloading from GitHub.
- Ensured the dataset is included in the repository.
@github-actions github-actions bot added tests good first issue Good for newcomers . Doesn't require extensive knowledge of the repo and package no releasenotes labels Jan 19, 2025
@wd60622
Copy link
Contributor

wd60622 commented Jan 19, 2025

Thanks for the PR! CI / CD is running then should be good to merge!

Copy link

codecov bot commented Jan 19, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.65%. Comparing base (8a0b076) to head (3902c1a).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1412   +/-   ##
=======================================
  Coverage   94.65%   94.65%           
=======================================
  Files          48       48           
  Lines        5257     5257           
=======================================
  Hits         4976     4976           
  Misses        281      281           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@wd60622 wd60622 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution @nayan2167 !

Hope to see you contribute again!

@wd60622 wd60622 merged commit 6f12316 into pymc-labs:main Jan 19, 2025
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers . Doesn't require extensive knowledge of the repo and package no releasenotes tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CLV dataset doesn't have to download from GitHub
2 participants