Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove sample_posterior_predictive_patch #1414

Merged
merged 2 commits into from
Jan 20, 2025
Merged

Conversation

wd60622
Copy link
Contributor

@wd60622 wd60622 commented Jan 20, 2025

Description

Remove the patch of sample_posterior_predictive since it only works for in-sample.

There is some docs added from previous PR:

import mlflow
from pymc_marketing.mmm import MMM
mmm = MMM(...)
mmm.fit(X, y)
predictions = mmm.sample_posterior_predictive(X)
with mlflow.start_run():
log_mmm_evaluation_metrics(y, predictions["y"])

Related Issue

Checklist

Modules affected

  • MMM
  • CLV
  • Customer Choice

Type of change

  • New feature / enhancement
  • Bug fix
  • Documentation
  • Maintenance
  • Other (please specify):

📚 Documentation preview 📚: https://pymc-marketing--1414.org.readthedocs.build/en/1414/

@wd60622 wd60622 requested a review from juanitorduz January 20, 2025 14:28
@github-actions github-actions bot added tests mlflow bug Something isn't working labels Jan 20, 2025
Copy link

codecov bot commented Jan 20, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.65%. Comparing base (2f6bc0a) to head (6a7df02).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1414      +/-   ##
==========================================
+ Coverage   94.58%   94.65%   +0.06%     
==========================================
  Files          49       49              
  Lines        5338     5330       -8     
==========================================
- Hits         5049     5045       -4     
+ Misses        289      285       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions github-actions bot added the MMM label Jan 20, 2025
@juanitorduz juanitorduz merged commit faa696e into main Jan 20, 2025
20 checks passed
@juanitorduz juanitorduz deleted the mmm-mlflow-changes branch January 20, 2025 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working mlflow MMM tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MLflow sample_posterior_predictive only works on in-sample data
2 participants