Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOC] improvement roas efficiency plot. mmm case study #1437

Merged
merged 3 commits into from
Jan 30, 2025

Conversation

juanitorduz
Copy link
Collaborator

@juanitorduz juanitorduz commented Jan 26, 2025

Similar to #1436


📚 Documentation preview 📚: https://pymc-marketing--1437.org.readthedocs.build/en/1437/

@juanitorduz juanitorduz self-assigned this Jan 26, 2025
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@juanitorduz juanitorduz added the docs Improvements or additions to documentation label Jan 26, 2025
@github-actions github-actions bot added the MMM label Jan 26, 2025
@juanitorduz juanitorduz requested a review from wd60622 January 26, 2025 11:17
Copy link
Contributor

@wd60622 wd60622 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

Thought: what if we just change the csv file to have the sorted columns and nice column names so none of processing happen in notebook?

@juanitorduz juanitorduz merged commit 6d83d4e into main Jan 30, 2025
8 checks passed
@juanitorduz juanitorduz deleted the mmm_case_study_improvments branch January 30, 2025 07:57
@juanitorduz
Copy link
Collaborator Author

Thought: what if we just change the csv file to have the sorted columns and nice column names so none of processing happen in notebook?

Good point! Still, I want to make sure the data is exactly the same as the original lightweight MMM example (pydata talk) I took the example from :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to documentation MMM
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants