Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add codecov to CI #32

Merged
merged 3 commits into from
Jan 31, 2024
Merged

Conversation

BenediktBurger
Copy link
Member

@BenediktBurger BenediktBurger commented Jan 30, 2024

Codecov seems to work even for other users forks.

This PR adds codecov (and probably removes the other one).

Maybe it's useful for pymeasure as well?

@BenediktBurger BenediktBurger linked an issue Jan 30, 2024 that may be closed by this pull request
@BenediktBurger BenediktBurger mentioned this pull request Jan 30, 2024
3 tasks
@cjermain
Copy link
Member

I'm a fan of Codecov and used it for a recent project (rust-python-coverage). I've enabled Codecov for all PyMeasure org repos. I'll circle back on a token in the repo secrets. @BenediktBurger or @bilderbuchi , can either of you access the token creation through the PyMeasure org permissions?
https://app.codecov.io/gh/pymeasure

@BenediktBurger
Copy link
Member Author

can either of you access the token creation through the PyMeasure org permissions?

I do not have access to the settings part of the pymeasure repos.

Copy link

codecov bot commented Jan 31, 2024

Welcome to Codecov 🎉

Once merged to your default branch, Codecov will compare your coverage reports and display the results in this comment.

Thanks for integrating Codecov - We've got you covered ☂️

@BenediktBurger BenediktBurger merged commit ab7ba64 into pymeasure:main Jan 31, 2024
17 checks passed
@BenediktBurger BenediktBurger deleted the add-codecov branch January 31, 2024 13:30
@BenediktBurger
Copy link
Member Author

Thanks @cjermain for adding codecov

@cjermain
Copy link
Member

cjermain commented Feb 1, 2024

I've added the appropriate secret token to both this repo and pymeasure.

@BenediktBurger
Copy link
Member Author

Thanks

@bilderbuchi
Copy link
Member

can either of you access the token creation through the PyMeasure org permissions?

I do not have access to the settings part of the pymeasure repos.

same here.

Thanks for adding this! I agree it could be useful for pymeasure, too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CI code coverage fails on external PR
3 participants