-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: extend exposure widget range #222
Conversation
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #222 +/- ##
=======================================
Coverage 91.18% 91.18%
=======================================
Files 65 65
Lines 8041 8041
=======================================
Hits 7332 7332
Misses 709 709
☔ View full report in Codecov by Sentry. |
Hi @tlambert03 I just realized that the same fix must be made at the MDA, when selecting the channel the minimum exposure is limited to 1ms as well. |
ah yes. thanks! |
Moreover, talking about the MDA, is it possible to run an acquisition without specifing a particular channel. Let's say I just created a .cfg file with a camera and my motorized microscope (I have not defined channels, nothing else), and I want to acquire a simple sequence of 1000 images. |
if it's not currently possible (and i believe it's not), it will be soon. The MDAWidget has recently undergone a full rewrite (#180 and #192) and work is underway to use the new ones in napari-micromanager (pymmcore-plus/napari-micromanager#292) ... We'll make sure it's possible to run an MDA without any channels in the process. (will create a new issue). |
@raulbola ... try again with v0.5.3 |
Hi @tlambert03 , I have been testing the MDA and i found some things:
Maybe I am missing something, but I though it was worth sharing that with you. |
@raulbola you are right! This is not an ideal behavior. But as @tlambert03 mentioned above, soon we will update |
Hi @fdrgsp , thank you very much for your quick response. If there is something I can help with, please let me know. |
@raulbola that's awesome you started using it! And feedbacks are always great! So we can fix bugs and improve the code! |
fixes the issue seen by @raulbola in pymmcore-plus/napari-micromanager#293 (comment)
you should be able to set an exposure below 1ms