Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: extend exposure widget range #222

Merged
merged 1 commit into from
Oct 12, 2023

Conversation

tlambert03
Copy link
Member

fixes the issue seen by @raulbola in pymmcore-plus/napari-micromanager#293 (comment)

you should be able to set an exposure below 1ms

@codecov
Copy link

codecov bot commented Oct 12, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (81cb02d) 91.18% compared to head (298830d) 91.18%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #222   +/-   ##
=======================================
  Coverage   91.18%   91.18%           
=======================================
  Files          65       65           
  Lines        8041     8041           
=======================================
  Hits         7332     7332           
  Misses        709      709           
Files Coverage Δ
src/pymmcore_widgets/_exposure_widget.py 90.62% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tlambert03 tlambert03 changed the title Fix: extend exposure widget range fix: extend exposure widget range Oct 12, 2023
@tlambert03 tlambert03 merged commit 54a7c33 into pymmcore-plus:main Oct 12, 2023
16 checks passed
@tlambert03 tlambert03 deleted the relax-exposure branch October 12, 2023 12:20
@raulbola
Copy link

Hi @tlambert03 I just realized that the same fix must be made at the MDA, when selecting the channel the minimum exposure is limited to 1ms as well.

@tlambert03
Copy link
Member Author

ah yes. thanks!

@raulbola
Copy link

Moreover, talking about the MDA, is it possible to run an acquisition without specifing a particular channel. Let's say I just created a .cfg file with a camera and my motorized microscope (I have not defined channels, nothing else), and I want to acquire a simple sequence of 1000 images.

@tlambert03
Copy link
Member Author

if it's not currently possible (and i believe it's not), it will be soon.

The MDAWidget has recently undergone a full rewrite (#180 and #192) and work is underway to use the new ones in napari-micromanager (pymmcore-plus/napari-micromanager#292) ... We'll make sure it's possible to run an MDA without any channels in the process. (will create a new issue).

@tlambert03
Copy link
Member Author

Hi @tlambert03 I just realized that the same fix must be made at the MDA, when selecting the channel the minimum exposure is limited to 1ms as well.

@raulbola ... try again with v0.5.3

@raulbola
Copy link

if it's not currently possible (and i believe it's not), it will be soon.

The MDAWidget has recently undergone a full rewrite (#180 and #192) and work is underway to use the new ones in napari-micromanager (pymmcore-plus/napari-micromanager#292) ... We'll make sure it's possible to run an MDA without any channels in the process. (will create a new issue).

Hi @tlambert03 , I have been testing the MDA and i found some things:

  • Actually the MDA can record a time or zstack sequence WITHOUT specifying a particular channel. For example if you load the default MM config file MMConfig_demo.cfg, and you open the MDA, the RUN button is clickable and you can indeed run sequences without specifying the channel.
  • However, when using the provided test_config.cfg, the RUN button becomes not clickable and you have to select a particular channel.
    Once you select the channel, and the time interval, the RUN button becomes clickable again. But here is what seems weird to me... if you now remove the channel and unselect the Channels tab, the RUN button becomes clickable again (even though you have not selected any channel).

Maybe I am missing something, but I though it was worth sharing that with you.

@fdrgsp
Copy link
Collaborator

fdrgsp commented Oct 13, 2023

@raulbola you are right! This is not an ideal behavior. But as @tlambert03 mentioned above, soon we will update napari-micromanager with the new MDAWidget (pymmcore-plus/napari-micromanager#292) and this issue should be fixed.

@raulbola
Copy link

Hi @fdrgsp , thank you very much for your quick response.
Sorry if I'm suddenly being very active with the issue, actually I'm very excited about the project.
I was afraid that these problems were due to misuse of napari-micromanager or poor definition of the configuration files.

If there is something I can help with, please let me know.

@fdrgsp
Copy link
Collaborator

fdrgsp commented Oct 13, 2023

Sorry if I'm suddenly being very active with the issue, actually I'm very excited about the project.

@raulbola that's awesome you started using it! And feedbacks are always great! So we can fix bugs and improve the code!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants