Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: accept bare string for mda event channel #130

Merged
merged 1 commit into from
Aug 13, 2023

Conversation

tlambert03
Copy link
Member

MDAEvent(channel="DAPI") == MDAEvent(channel={"config": "DAPI"})

@codecov
Copy link

codecov bot commented Aug 12, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.13% 🎉

Comparison is base (74f2690) 98.01% compared to head (b5347a0) 98.15%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #130      +/-   ##
==========================================
+ Coverage   98.01%   98.15%   +0.13%     
==========================================
  Files          14       14              
  Lines         808      811       +3     
==========================================
+ Hits          792      796       +4     
+ Misses         16       15       -1     
Files Changed Coverage Δ
src/useq/_mda_event.py 90.19% <100.00%> (+2.69%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tlambert03 tlambert03 merged commit 7652953 into pymmcore-plus:main Aug 13, 2023
@tlambert03 tlambert03 deleted the channel-str branch August 13, 2023 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant