Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow RandomPoints.start_at to be a position #179

Merged
merged 2 commits into from
Jul 8, 2024

Conversation

tlambert03
Copy link
Member

this allows the start_at field of RandomPoints to be an actual position, with semantics:

    start_at : int | RelativePosition
        Position or index of the point to start at. This is only used if `order` is
        'nearest_neighbor' or 'two_opt'.  If a position is provided, it will *always*
        be included in the list of points. If an index is provided, it must be less than
        the number of points, and corresponds to the index of the (randomly generated)
        points; this likely only makes sense when `random_seed` is provided.

@tlambert03 tlambert03 changed the title allow start_at to be a point feat: allow start_at to be a point Jul 8, 2024
Copy link

codecov bot commented Jul 8, 2024

Codecov Report

Attention: Patch coverage is 80.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 93.76%. Comparing base (b623130) to head (4f01d17).

Files Patch % Lines
src/useq/_grid.py 76.92% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #179      +/-   ##
==========================================
- Coverage   93.97%   93.76%   -0.22%     
==========================================
  Files          18       18              
  Lines        1179     1187       +8     
==========================================
+ Hits         1108     1113       +5     
- Misses         71       74       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tlambert03 tlambert03 merged commit 4806863 into pymmcore-plus:main Jul 8, 2024
24 of 26 checks passed
@tlambert03 tlambert03 deleted the allow-startat-pos branch July 8, 2024 23:59
@tlambert03 tlambert03 changed the title feat: allow start_at to be a point feat: allow RandomPoints.start_at to be a position Jul 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant