Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: make None imply no selected wells #186

Merged
merged 2 commits into from
Sep 12, 2024

Conversation

tlambert03
Copy link
Member

this makes all "falsey" values to selected_wells in the WellPlatePlan imply no selected wells (rather than all selected wells)

Copy link

codecov bot commented Sep 12, 2024

Codecov Report

Attention: Patch coverage is 71.42857% with 2 lines in your changes missing coverage. Please review.

Project coverage is 93.64%. Comparing base (5bf36c6) to head (bd4dc40).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/useq/_plate.py 71.42% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #186      +/-   ##
==========================================
- Coverage   93.78%   93.64%   -0.14%     
==========================================
  Files          18       18              
  Lines        1222     1228       +6     
==========================================
+ Hits         1146     1150       +4     
- Misses         76       78       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tlambert03 tlambert03 merged commit fe35207 into pymmcore-plus:main Sep 12, 2024
23 of 25 checks passed
@tlambert03 tlambert03 deleted the plate-none-behavior branch September 12, 2024 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant