New iterator pattern [wip] #192
Open
+578
−45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit refactors the AxisIterator and TimePlan classes in the example.py file. The changes include: - Adding type hints and annotations to improve code readability and maintainability. - Renaming the `length` method in AxisIterator to `num_timepoints` for clarity. - Adding a new `deltas` method to TimePlan to iterate over the time deltas between timepoints. - Handling the case of an infinite sequence in the `num_timepoints` method of TimePlan. These changes improve the overall structure and functionality of the code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
very very wip example that would solve #156 and #5 and #137