-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pyproject: fix classifiers #353
Conversation
PR #337 (9d098f3) introduced new classifiers, some of which cause the build to abort: ``` $ python -m flit build --format wheel Fetching list of valid trove classifiers I-flit.validate Unrecognised classifier: 'Programming Language :: Python :: 3 :: 3.10' E-flit.validate Unrecognised classifier: 'Programming Language :: Python :: 3 :: 3.7' E-flit.validate Unrecognised classifier: 'Programming Language :: Python :: 3 :: 3.8' E-flit.validate Unrecognised classifier: 'Programming Language :: Python :: 3 :: 3.9' E-flit.validate Config error: Invalid config values (see log) ``` Looking at PyPI’s list of valid classifiers [1] confirms that minor version classifiers have no intermediate `3` element. Remove the intermediate elements of affected classifiers. [1]: https://pypi.org/pypi?%3Aaction=list_classifiers CC: William Woodruff <[email protected]>
Thanks for catching this! That’s strange about the Makefile, I’ll look into that…
Changes LGTM; I’ll merge this evening.
Sent from mobile. Please excuse my brevity.
… On Aug 18, 2022, at 2:22 PM, CLAassistant ***@***.***> wrote:
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you were mentioned.
|
Not sure what happened to the CI pipeline here, opening/closing in an attempt to reset it. |
Yeah, looks like it was this: https://www.githubstatus.com/incidents/8gpymn7rystj |
This is strange -- the Makefile should be using Flit via its standard build APIs, since that's what I wonder if it's a discrepancy between |
It also doesn't make sense to me -- would be worthwhile to try to get to the bottom of it. |
I think it's because Locally, $ python -m flit build
Fetching list of valid trove classifiers I-flit.validate
Unrecognised classifier: 'Programming Language :: Python :: 3 :: 3.10' E-flit.validate
Unrecognised classifier: 'Programming Language :: Python :: 3 :: 3.7' E-flit.validate
Unrecognised classifier: 'Programming Language :: Python :: 3 :: 3.8' E-flit.validate
Unrecognised classifier: 'Programming Language :: Python :: 3 :: 3.9' E-flit.validate
Config error: Invalid config values (see log) But $ python -m build
* Creating venv isolated environment...
* Installing packages in isolated environment... (flit_core >=3.2,<4)
* Getting dependencies for sdist...
* Building sdist...
* Building wheel from sdist
* Creating venv isolated environment...
* Installing packages in isolated environment... (flit_core >=3.2,<4)
* Getting dependencies for wheel...
* Building wheel...
Successfully built pip_audit-2.4.3.tar.gz and pip_audit-2.4.3-py3-none-any.whl I'll investigate further. |
Specifically, it looks like the error happens in |
Ref: pypa/flit#580 |
PR #337 introduced new classifiers, some of which cause the build to abort:
Looking at PyPI’s list of valid classifiers confirms that minor version classifiers have no intermediate
3
element.I think the reason that the CI never caught this issue is that because the Makefile seems not to use Flit.
This PR removes the intermediate elements of affected classifiers.
btw:
Shoutout to @woodruffw and others for your amazing work!