-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate examples to src-layout
#25
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❤️
Thank you very much, @chrysle
@chrysle I have an advice for maintaining PR branches — always use forks, even if you have full upstream access. To arbitrary users, the branch list like https://github.com/pypa/sample-namespace-packages/branches/all is confusing. Moreover, when contributors fork the repo, they may get copies of those branches at the moment of forking but won't get branch updates as they are modified upstream or cleaned up, effectively leaving them with non-collected garbage in their forks. |
Thanks for the advice, I'll stick to this in the future (only I would have to close this because GH doesn't allow for changing PR branches, AFAIK). BTW, could you re-visit the neighbouring PR? |
@chrysle yeah, no need to close. Just keep in mind for the future. |
c255b01
to
3c38bbc
Compare
3c38bbc
to
b042b0b
Compare
@abravalheri FYI added a |
Hi @chrysle, the presence of the legacy table is something that depends on the README. Previously, we had:
As a nod to the historical data in the repo (e.g. maybe there is a link somewhere referencing this repo and talking about the differences between 2.7 and 3) so that we don't remove historical data and keep consistency with old references. If that is something you removed, it might be fine to remove the file in the branch, too. Or update the link to reference a different branch |
Done! |
50fd6e0
to
8bfa373
Compare
This pull requests transfers the
src
-layout into a separate branch - this will need to be merged with the main branch regularly, preserving the layout-related changes. We'll still have to add a note to the README onmaster
.When this is approved, I'll also create a legacy table.