Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use (test)pypi in Trusted Publishing placeholder for GitHub Environments #17036

Merged
merged 7 commits into from
Nov 7, 2024

Conversation

webknjaz
Copy link
Member

@webknjaz webknjaz commented Nov 5, 2024

GitHub Environments is a confusingly explained feature within GitHub that represents deployment targets. When projects get uploaded to PyPI — that a deployment target; same for TestPyPI. They don't represent processes but server-like entities. So using release is conceptually incorrect and gives people the wrong idea of what it is.

This is actually connected to Deployments API (and corresponding events) on the GitHub platform. The name Environments is just a misleading interface to describe Deployments that appears in some parts of the ecosystem, like GitHub Actions CI/CD.

In other places, it's called deployments and there's even a tab in repositories using it: https://github.com/cherrypy/cheroot/deployments/pypi. Each deployment can be linked to the corresponding released project version URL.

This patch attempts to align the practices with those used in the PyPUG guide and GitHub docs/starters: https://packaging.python.org/guides/publishing-package-distribution-releases-using-github-actions-ci-cd-workflows/ / actions/starter-workflows#2345.

Additionally, this patch deletes the i18n marker, as I believe it shouldn't have been made translatable in the first place.

…ments

GitHub Environments is a confusingly explained feature within GitHub that represents deployment targets. When projects get uploaded to PyPI — that a deployment target; same for TestPyPI. They don't represent processes but server-like entities. So using `release` is conceptually incorrect and gives people the wrong idea of what it is.

This is actually connected to Deployments API (and corresponding events) on the GitHub platform. The name Environments is just a misleading interface to describe Deployments that appears in some parts of the ecosystem, like GitHub Actions CI/CD.

In other places, it's called deployments and there's even a tab in repositories using it: https://github.com/cherrypy/cheroot/deployments/pypi. Each deployment can be linked to the corresponding released project version URL.

This patch attempts to align the practices with those used in the PyPUG guide and GitHub docs: actions/starter-workflows#2345.
@webknjaz webknjaz requested a review from a team as a code owner November 5, 2024 17:03
@webknjaz webknjaz requested a review from woodruffw November 5, 2024 17:03
@webknjaz webknjaz added translation Issues relating to PyPI translations trusted-publishing labels Nov 5, 2024
@webknjaz
Copy link
Member Author

webknjaz commented Nov 5, 2024

@woodruffw we talked about this in the past, I finally got a minute to try to update it. Are there any other places? Also, feel free to take over if something needs updating. I made changes from browser, so there's no translation template file updates.

@woodruffw
Copy link
Member

@woodruffw we talked about this in the past, I finally got a minute to try to update it. Are there any other places? Also, feel free to take over if something needs updating. I made changes from browser, so there's no translation template file updates.

Thanks for doing this! I think those are the main places.

If you'd like, you can give me the commit bit on your fork and I'll run make translations. Otherwise, a PyPI admin will need to do it (or recreate a new PR).

@webknjaz
Copy link
Member Author

webknjaz commented Nov 6, 2024

Oh, I thought ✅ Allow edits and access to secrets by maintainers took care of that..

@webknjaz
Copy link
Member Author

webknjaz commented Nov 6, 2024

@woodruffw invited!

@woodruffw
Copy link
Member

Oh, I thought ✅ Allow edits and access to secrets by maintainers took care of that..

Only for real maintainers, I am merely a lowly triager 😉

Signed-off-by: William Woodruff <[email protected]>
@webknjaz webknjaz requested a review from miketheman November 6, 2024 19:15
@webknjaz
Copy link
Member Author

webknjaz commented Nov 6, 2024

Oh, so I'll ask Mike for review too, then. I also only have triage IIRC :)

Copy link
Member

@di di left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@di di enabled auto-merge (squash) November 7, 2024 17:05
@di di merged commit 6d60f0e into pypi:main Nov 7, 2024
20 checks passed
@webknjaz
Copy link
Member Author

webknjaz commented Nov 7, 2024

Not sure if the same makes sense for GitLab. I haven't used it in a while so I didn't attempt updating. Somebody who knows the GL concept mapping should evaluate that, I think.

@woodruffw woodruffw deleted the patch-1 branch November 7, 2024 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
translation Issues relating to PyPI translations trusted-publishing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants