Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revise visualisations #18

Merged
merged 14 commits into from
Aug 15, 2023
Merged

Revise visualisations #18

merged 14 commits into from
Aug 15, 2023

Conversation

ekatef
Copy link
Member

@ekatef ekatef commented Aug 11, 2023

PR aims to make visualisations more clear for a modeller. Main changes introduced:

  1. added a generation and load parameters for the spatial plot (partially addresses Add content to spatial plots #9);
  2. generators to be shown by color filling are filtered to be renewable only (partially addresses Add content to spatial plots #9);
  3. revised layout for System Operation: only Suppy and Demand plot are left at the moment to keep the focus;
  4. revised labels and content of Suppy and Demand plots (partially addresses Improve time-series plots #10)

@ekatef
Copy link
Member Author

ekatef commented Aug 11, 2023

Hello @drifter089! Have revised visualisations a bit.

The idea is to make plots correct and as nice and clear as we can, as the first step. Once we'll be happy with the results, the commented-out plots and selections can be get back.

Feel free to disagree and comment on the suggested changes :)

@ekatef
Copy link
Member Author

ekatef commented Aug 11, 2023

@drifter089 @pz-max I believe that is ready for review 🙂

@pz-max
Copy link
Member

pz-max commented Aug 14, 2023

Feel free to merge after review from @drifter089

@pz-max pz-max merged commit 264eb52 into pypsa-meets-earth:main Aug 15, 2023
@pz-max
Copy link
Member

pz-max commented Aug 15, 2023

Reviewed and merged. Just found this issue here that there is two times p_nom (nominal power with somewhat different results being plotted)
image

@ekatef
Copy link
Member Author

ekatef commented Aug 15, 2023

Reviewed and merged. Just found this issue here that there is two times p_nom (nominal power with somewhat different results being plotted)

Thanks for review @pz-max! There are currently both p_nom and p_nom_opt, although agree that p_nom is not very meaningful and can be misleading. Fixing it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants